Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat change protocol flag calling position #1039

Merged
merged 19 commits into from
Jan 16, 2025
Merged

Feat change protocol flag calling position #1039

merged 19 commits into from
Jan 16, 2025

Conversation

alenmestrov
Copy link
Member

Change position of setting --protocol flag from node init step to context create step

@alenmestrov alenmestrov self-assigned this Jan 14, 2025
@alenmestrov alenmestrov changed the title Feat change protocol flag position Feat change protocol flag calling position Jan 14, 2025
miraclx
miraclx reviewed Jan 15, 2025
View reviewed changes
crates/meroctl/src/cli/context/create.rs Outdated Show resolved Hide resolved
crates/node/src/interactive_cli/context.rs Outdated Show resolved Hide resolved
crates/server-primitives/src/admin.rs Outdated Show resolved Hide resolved
crates/meroctl/src/cli/bootstrap/start.rs Outdated Show resolved Hide resolved
crates/meroctl/src/cli.rs Outdated Show resolved Hide resolved
@alenmestrov alenmestrov requested a review from miraclx January 16, 2025 08:15
@fbozic
Copy link
Member

fbozic commented Jan 16, 2025

You are gonna have to adjust e2e tests as well since you have modified the public API.

@frdomovic frdomovic marked this pull request as ready for review January 16, 2025 12:08
@frdomovic
Copy link
Member

Few things I'm missng:
How do you get list of available protocols for the flag?
Screenshot 2025-01-16 at 13 24 40
And where can I see on what protocol was context created? Maybe add additional field to context ls saying which protocol it was
Screenshot 2025-01-16 at 13 25 23

miraclx
miraclx approved these changes Jan 16, 2025
View reviewed changes
crates/meroctl/src/cli/context/create.rs Outdated Show resolved Hide resolved
crates/meroctl/src/cli/context/create.rs Outdated Show resolved Hide resolved
crates/node/src/interactive_cli/context.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

E2E tests report

Scenario: kv-store

Protocol/Step 0. app install (AllMembers) 1. ctx create 2. call (set, Inviter) 3. call (get, Inviter) 4. ctx invite-join 5. call (get, AllMembers)
near ✅ ✅ ✅ ✅ ✅ ✅
icp ✅ ✅ ✅ ✅ ✅ ✅

@alenmestrov alenmestrov merged commit ea8b277 into master Jan 16, 2025
9 of 10 checks passed
@alenmestrov alenmestrov deleted the feat_change_protocol_flag branch January 16, 2025 16:21
frdomovic
frdomovic reviewed Jan 24, 2025
View reviewed changes
node-ui/src/components/login/applicationLogin/StartContextPopup.tsx
</option>
<option value="near">NEAR</option>
<option value="ethereum">Ethereum</option>
<option value="solana">Solana</option>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not available yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frdomovic frdomovic frdomovic left review comments

@miraclx miraclx miraclx approved these changes

@fbozic fbozic Awaiting requested review from fbozic

Assignees

@alenmestrov alenmestrov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alenmestrov @fbozic @frdomovic @miraclx